improve tests structure (visibility and clearness of arrange/act/assert blocks)

[yashaka]

This is a parent issue. For PR, break it into issues per test file to refactor, once created – link them. Send PRs - one per test file!

Imagine you have this kind of test:

    page = GivenPage(session_browser.driver)
    page.opened_empty()

    elements = session_browser.all('.will-appear')

    page.load_body(
        '''
                   <ul>Hello to:
                       <li class='will-appear'>Bob</li>
                       <li class='will-appear' style='display:none'>Kate</li>
                   </ul>'''
    )

    assert len(elements) == 2

It's unclear from first sight where is precondition, where this step and assert blocks (aka arrange/act/assert or given/when/then). This influces its readability, let's improve it to the following style with clear break down into 3 corresponding blocks:

def test_counts_invisible_tasks(session_browser):
    page = GivenPage(session_browser.driver)
    page.opened_empty()
    page.load_body(
        '''
        <ul>Hello to:
            <li class='will-appear'>Bob</li>
            <li class='will-appear' style='display:none'>Kate</li>
        </ul>
        '''
    )
    elements = session_browser.all('.will-appear')
    
    length = len(elements)

    assert length == 2

[aleksandr-kotlyar]

Before refactor this - need to review a huge PR #283 with test migration from selene version 1 to selene version 2.

Update: #283 has been merged as is by agreement with @yashaka.

[rina-tenitska]

I will do

[yashaka]

@rina-tenitska, great!
Please, refactor files – 1 by 1 and each time:

• create a new issue named improve tests structure of $FILE_NAME
• link this issue to this improve tests structure (visibility and clearness of arrange/act/assert blocks) #313
• and send corresponding PR linked to such sub-issue

Other contributors can do the same by the way, this is a big task, and can be done by more than 1 contributor ;)

[yashaka]

let's also reduce the scope of this issue just to tests inside https://github.com/yashaka/selene/tree/master/tests/integration

[Dbhardwaj99]

Heyy, Is this issue still open? Would Like to contribute

[yashaka]

@Dbhardwaj99
I don't remember:) It might be still relevant :) Need to check)
But if you find something to improve in context of test structure of some tests, propose it here!

[Dbhardwaj99]

Sure