Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes in Navbar and Footer #60

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Rashmisingh-18
Copy link

Related Issue

Improved CSS of Navbar and Footer

Closes: #39

Are you creating this PR under Hacktoberfest

Yes, I'm opening this PR under hacktoberfest. (Please remove this section if you are not a hacktoberfest participant)

Describe the changes you've made

Changes in Navbar and Footer.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.

Screenshots

Put any screenshot(s) of the project here.
Nav
Footer

@Rashmisingh-18
Copy link
Author

@yashikabhargava, could you please reply to why it is showing conflicting files? I'm not able to get this.

@yashikabhargava
Copy link
Owner

yashikabhargava commented Oct 6, 2022

@yashikabhargava, could you please reply to why it is showing conflicting files? I'm not able to get this.

I'm sorry for the late reply, the conflicts were there because your fork was not in sync with the original one.

@yashikabhargava
Copy link
Owner

@Rashmisingh-18 can you please move all the script that you have added in index.html to main.js

@Rashmisingh-18
Copy link
Author

Please accept this pr, or reply if any changes required.

@yashikabhargava
Copy link
Owner

yashikabhargava commented Oct 18, 2022

@Rashmisingh-18 This PR has a lot of conflicts. Kindly resolve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving the UI
2 participants