Remove tags from lyrics #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ritiek, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yask123, @sulami and @atuljangra to be potential reviewers. |
yask123
reviewed
Oct 30, 2016
| @@ -178,13 +178,11 @@ def query_and_download(search, has_prompts=True, is_quiet=False): | |||
| except: | |||
| print ('Cant get album name') | |||
| try: | |||
| test1 = ('') | |||
There was a problem hiding this comment.
Can we have more verbose variable names ? I know it wasn't much verbose before either, but now is a good opportunity to fix that.
| test1= (test1.replace('<br/>',' ')) | ||
| test1 = test1.replace('</p>',' ') | ||
| for line in raw_lyrics: | ||
| test1 = test1 + str(line.get_text()) + '\n' |
| test1 = test1.replace('</p>',' ') | ||
| for line in raw_lyrics: | ||
| test1 = test1 + str(line.get_text()) + '\n' | ||
|
|
||
| print (test1) |
|
I've changed the variable names.. Does it look okay now? |
|
@ritiek Looks much better now. Just one more thing, can you squash all commits into one before I merge this? |
|
@yask123 I'm not sure but isn't it the author of the repo who chooses this at the time of merge? |
|
Yea @ritiek you are right. Github added this feature lately, I had forgotten about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents tags like
<br>, <p>, </p> ..etc. from being present in the output lyrics.(the old code did not seem to work somehow)