First stage only DNS setup tests #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
approved these changes
Jun 21, 2017
aytests/dns_setup.sh
Outdated
|
|
||
| set -e -x | ||
|
|
||
| fgrep -q 'WRITE_HOSTNAME_TO_HOSTS="no"' /etc/sysconfig/network/dhcp || exit 1 |
There was a problem hiding this comment.
If I am not wrong, as you're using set -e, you won't need to call exit. It will stop on the first command that fails.
There was a problem hiding this comment.
Yeah that is exactly what happens when doing copy paste development ;-) I'll tweak it, thanks
package/aytests-tests.changes
Outdated
|
|
||
| - Test for configuring DNS when running first stage only | ||
| - Bumping version since the feature is SLE-15 only | ||
| - 1.2.0 |
|
Does "See yast/yast-network#520" mean that we must wait with merging until after that one is merged? |
|
It doesn't make sense to merge it before that, so yes |
mchf
force-pushed
the
first_stage_network
branch
from
4b5c906
to
557c1e1
Compare
|
Fixed conflict in the changelog. Thanks for reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See yast/yast-network#520