Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert MarkDown tests to Cucumber #1

Merged
merged 5 commits into from
Dec 16, 2014
Merged

convert MarkDown tests to Cucumber #1

merged 5 commits into from
Dec 16, 2014

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Dec 15, 2014

  • Replaced MarkDown test descriptions (taken from Zombie Killer) by Cucumber
  • Removed our own MarkDown -> RSpec generator
  • Use Cucumber (upstream standard)
  • See https://travis-ci.org/yast/rubocop-yast/builds/44026313#L218 for Cucumber output
  • SimpleCov merges RSpec and Cucumber code coverage automatically (the total coverage is unchanged)

mvidner
mvidner reviewed Dec 15, 2014
View reviewed changes
features/builtins_cop.feature

Some Builtin calls are not detected as an offense and are kept unchanged.
That include the calls which do not have native ruby replacement, like lsort()
or crytp() functions, or the replacement would be too complex (the gettext
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crypt

@mvidner
Copy link
Member

mvidner commented Dec 15, 2014

Great! I like that we adopt a standard tool. The output formatting is only slightly worse than the custom renderer. It even supports data tables which we wanted to add to the zombie killer renderer :)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6448f64 on cucumber into bbd1738 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 68d79ee on cucumber into bbd1738 on master.

@mvidner
Copy link
Member

mvidner commented Dec 16, 2014

Yay! LGTM.

lslezak added a commit that referenced this pull request Dec 16, 2014
@lslezak
Merge pull request #1 from yast/cucumber
bd338a5 
convert MarkDown tests to Cucumber
@lslezak lslezak merged commit bd338a5 into master Dec 16, 2014
@lslezak lslezak deleted the cucumber branch December 18, 2014 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lslezak @mvidner @coveralls