Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed unit tests, verifying doubles, fixed handling of invalid XML #2

Merged
merged 3 commits into from Jan 19, 2022
Merged

Fixed unit tests, verifying doubles, fixed handling of invalid XML #2

merged 3 commits into from Jan 19, 2022

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Jan 19, 2022

  • Fixed bunch of failing unit tests
  • Enable the unit tests in RPM build again
  • Enabled verifying doubles
  • Updated code coverage reporting
  • Handle invalid XML files

(There are still some CI checks failing, but let's solve that later, I already spent too much time here...)

@lslezak lslezak mentioned this pull request Jan 19, 2022
Closed
dgdavid
dgdavid approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib/y2sap/clients/create_storage.rb
@@ -103,6 +103,8 @@ def read_partitioning

profile = Yast::XML.XMLToYCPFile(filename)
profile && profile["partitioning"]
rescue Yast::XMLDeserializationError
nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we log something there?

Copy link
Member Author

@lslezak lslezak Jan 19, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! 👍

@dgdavid
Copy link
Member

dgdavid commented Jan 19, 2022

(There are still some CI checks failing, but let's solve that later, I already spent too much time here...)

👍 Thank you for taking care!

@lslezak lslezak merged commit 4295da6 into master Jan 19, 2022
@lslezak lslezak deleted the verifying_doubles branch January 20, 2022 08:07
@yast-bot
Copy link

yast-bot commented Feb 9, 2023

❌ Internal Jenkins job #1 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgdavid dgdavid dgdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lslezak @dgdavid @yast-bot