Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CaaSP 4 pulls images from SUSE Registry, so we don't need #75

Merged
merged 1 commit into from
Oct 16, 2018
Merged

CaaSP 4 pulls images from SUSE Registry, so we don't need #75

merged 1 commit into from
Oct 16, 2018

Conversation

jordimassaguerpla
Copy link
Contributor

container-feeder anymore

Signed-off-by: Jordi Massaguer Pla jmassaguerpla@suse.de

@jordimassaguerpla
Copy link
Contributor Author

@teclator : Hi! Could you take a look at these one? Our devel isos are broken because of this, since we are not installing container-feeder but yast tries to start the service. Thanks.

@teclator
Copy link
Contributor

For me it is fine, but It needs a bug report / or a feature request and the the changelog entry as well.

@jordimassaguerpla
Copy link
Contributor Author

@teclator : I just opened a bug and rebased this commit so it contains the reference in the changelog and increased the version to reflect that.
Could you review again?

@teclator
Copy link
Contributor

@jordimassaguerpla it still has some pending conflict, you should rebase it with master.

teclator
teclator requested changes Oct 15, 2018
View reviewed changes
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase with master

@jordimassaguerpla
CaaSP 4 pulls images from SUSE Registry, so we don't need
ede4bd8 
container-feeder anymore

Signed-off-by: Jordi Massaguer Pla <jmassaguerpla@suse.de>
@jordimassaguerpla
Copy link
Contributor Author

Rebased with master.

@teclator
Copy link
Contributor

LGTM

@teclator teclator merged commit 0ccbad1 into yast:master Oct 16, 2018
@yast-bot
Copy link

✔️ Public Jenkins job #4 successfully finished
✔️ Created OBS submit request #642234

@yast-bot
Copy link

✔️ Internal Jenkins job #4 successfully finished
✔️ Created IBS submit request #174767

@teclator
Copy link
Contributor

Created request to SUSE:SLE-15:Update:Products:CASP40 (https://build.suse.de/request/show/174773)

@yast-bot
Copy link

yast-bot commented Nov 7, 2018

❌ Internal Jenkins job #1 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teclator teclator teclator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jordimassaguerpla @teclator @yast-bot