Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a failed unit test #105

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Fixed a failed unit test #105

merged 2 commits into from
Sep 17, 2020

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Sep 17, 2020

  • Just reset the flag back for the other tests
  • Some tests failed in OBS build though it was fine locally and in Travis, probably triggered by a different test order
  • The errors were:
[    4s] Failures:
[    4s] 
[    4s]   1) Yast::AddOnAddOnWorkflowInclude.media_type_selection Full medium installation with no add-ons yet not registered preselects the installation URL for the add-ons
[    4s]      Failure/Error: expect(Yast::InstURL).to receive(:installInf2Url)
[    4s] 
[    4s]        (#<Yast::InstURLClass:0x000056530fff7d10 @my_textdomain=["packager"], @installInf2Url=nil>).installInf2Url(*(any args))
[    4s]            expected: 1 time with any arguments
[    4s]            received: 0 times with any arguments
[    4s]      # ./test/add-on-workflow_test.rb:39:in `block (5 levels) in <top (required)>'
[    4s] 
[    4s]   2) Yast::AddOnAddOnWorkflowInclude.media_type_selection Full medium installation with no add-ons yet not registered returns the :finish symbol
[    4s]      Failure/Error: expect(subject.media_type_selection).to eq(:finish)
[    4s] 
[    4s]        expected: :finish
[    4s]             got: nil
[    4s] 
[    4s]        (compared using ==)
[    4s]      # ./test/add-on-workflow_test.rb:45:in `block (5 levels) in <top (required)>'

@coveralls
Copy link

coveralls commented Sep 17, 2020

Coverage Status

Coverage remained the same at 25.075% when pulling be031bc on test_fixup into 1ef42cb on SLE-15-SP2.

@mvidner
Copy link
Member

mvidner commented Sep 17, 2020

When I try to reproduce this reliably with

rspec ./test/add-on-workflow_test.rb

I get "uninitialized constant Yast::AddOnProduct"

@wfeldt
Copy link
Member

wfeldt commented Sep 17, 2020

I get "uninitialized constant Yast::AddOnProduct"

True, but that's also the case in master, afaics.

Copy link
Member

@wfeldt wfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lslezak lslezak merged commit 1f7a305 into SLE-15-SP2 Sep 17, 2020
@lslezak lslezak deleted the test_fixup branch September 17, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants