-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UX using generic error message for unknown repo URL #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the screenshots, I found a bit weird having the
Repository URL: Unknown repository URL
In the box to show more details below the list once the repo is selected.
Should we update that label too?
Regarding the details in the box below, I'd omit the On the other hand for the repositories we find we should also show the repository name, that's probably more interesting and shorter/easier to remember than an URL. |
Ah, I see, then I think it is OK, we do not need to change that. (But I still think we should also display the name because YaST basically shows the name everywhere, alias is not displayed anywhere except this place.) |
I have removed the |
aliases = info.fetch("aliases", []).join(",") | ||
|
||
details = [] | ||
details << format(_("<b>Vendor:</b> %s<br>"), vendor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this changes a bit the translation since former %1
is now %s
but... I hope it does not hurt. If so, I can revert the last commit completely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately in my experience the translators quite often overlook such small differences and they just reuse the old translations. 😟
But we have the check_po_files.rb for that reason. I run it from time to time and do fixes like this.
So go ahead, I'll run the script after few days to fix the problems. 😃
Co-authored-by: Ladislav Slezák <lslezak@suse.cz>
✔️ Public Jenkins job #49 successfully finished |
✔️ Internal Jenkins job #30 successfully finished |
Problem
When an add-on repository is disable (e.g., after finishing the installation the DVD repositories get automatically disabled), yast2 add-on shows the "Unknown URL" label as URL, which is a bit misleading.
Solution
To use a more generic text "Not found in enabled repositories".
Additionally,
Repository URL
is not shown anymore in the details boxBuiltins
)Screenshots