Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable RSpec verifying doubles (bsc#1194784) #124

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Enable RSpec verifying doubles (bsc#1194784) #124

merged 1 commit into from
Jan 20, 2022

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Jan 20, 2022

  • Enable RSpec verifying doubles in unit tests to ensure that the mocked methods really exist

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 30.483% when pulling ff7c48d on verifying_doubles into 36e6438 on master.

teclator
teclator approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit 9ce5849 into master Jan 20, 2022
@lslezak lslezak deleted the verifying_doubles branch January 20, 2022 19:46
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #60 successfully finished
✔️ Created OBS submit request #947768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teclator teclator teclator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lslezak @coveralls @yast-bot @teclator