Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Ignore extra white space in URL (bsc#1205928) #129

Merged
merged 7 commits into from Dec 15, 2022
Merged

[master] Ignore extra white space in URL (bsc#1205928) #129

merged 7 commits into from Dec 15, 2022

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Dec 15, 2022 •
edited

Screenshots

Original popup
add_on_question

New popup
add_on_question_improved

@coveralls
Copy link

coveralls commented Dec 15, 2022 •
edited

Coverage Status

Coverage increased (+0.1%) to 30.653% when pulling 2af88f0 on strip_url_master into 931ab03 on master.

mvidner
mvidner approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also with new popup

@lslezak lslezak merged commit a6fd1f0 into master Dec 15, 2022
@lslezak lslezak deleted the strip_url_master branch December 15, 2022 15:10
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #66 successfully finished
✔️ Created OBS submit request #1043163

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #42 successfully finished
✔️ Created IBS submit request #286652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvidner mvidner mvidner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lslezak @coveralls @yast-bot @mvidner