Fix the repo name selection #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was broken after the refactorization of AddOn auto client, due to a wrong use of `.fetch`. The test has been also adapted to increase the coverage of method in charge to select the name.
jreidinger
approved these changes
Sep 14, 2018
|
✔️ Public Jenkins job #9 successfully finished |
|
✔️ Internal Jenkins job #11 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://bugzilla.suse.com/show_bug.cgi?id=1108139
During the AddOn auto client refactorization a typo was introduced at the time to get the repo name, asking for
mediakey instead of the rightmedia_url. In addition, also the default value for.fetchwas forgotten.This PR fix those bugs and the implied test has been adapted a little to ensure a minimum coverage of the
preferred_name_formethod.