Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Do not abort the installation when an addon EULA is refused #79

Merged
merged 6 commits into from Jul 2, 2019

Conversation

dgdavid
Copy link
Member

@dgdavid dgdavid commented Jul 1, 2019

🚨 Update: a wrong change introduced here has been fixed in #90. See the comment below

📝 Similar to #78, but for master (aka SLE-15-SP2)

Problem

When user refuses an addon's EULA (doing click in "Next" without check the I Agree to the License Terms.) the installation is completely aborted.

Solution

just go ahead refusing the license and not installing/registering the addon, according to the message shown to the user.

Show/hide screenshot

Screenshot_sles12-sp4_2019-06-19_11_28_47
The message shown to the user, from an SLE-12 Screenshot (still being the same)


To do that, it has been necessary to update yast2-packager too (see yast/yast-packager#456), in order to support "refuse" as a cancel action. Otherwise, it is not possible to distinguish when the "abort" means "to refuse the license agreement" or "abort the installation".

Tests

  • Only tested manually via driver update.

schubi2 and others added 6 commits May 23, 2019 10:05
*  Initialize update repo correctly in the add-ons
Allowing to refuse an EULA without aborting the installation
(bsc#1114018).
Co-Authored-By: Ladislav Slezák <lslezak@suse.cz>
[SLE-15-SP1] Do not abort the installation when an addon EULA is refused
@dgdavid dgdavid requested a review from lslezak July 1, 2019 11:30
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 18.743% when pulling 05100cd on feature/bsc-1114018-sle15sp2 into 9f98a69 on master.

@dgdavid dgdavid merged commit 9b052c6 into master Jul 2, 2019
@dgdavid dgdavid deleted the feature/bsc-1114018-sle15sp2 branch July 2, 2019 09:32
@yast-bot
Copy link
Contributor

yast-bot commented Jul 2, 2019

✔️ Public Jenkins job #19 successfully finished
✔️ Created OBS submit request #713016

@yast-bot
Copy link
Contributor

yast-bot commented Jul 2, 2019

✔️ Internal Jenkins job #3 successfully finished
✔️ Created IBS submit request #195839

@dgdavid
Copy link
Member Author

dgdavid commented Nov 22, 2019

This break here avoid the right propagation of the user input from the sub-workflow (aka ret2) to the main workflow (aka ret).

Fixed in #90

Copy link
Member Author

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented, the break introduced here breaks the installer workflow when user is going :back. Fixed in #90.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants