New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] Do not abort the installation when an addon EULA is refused #79
Conversation
Allowing to refuse an EULA without aborting the installation (bsc#1114018).
Co-Authored-By: Ladislav Slezák <lslezak@suse.cz>
[SLE-15-SP1] Do not abort the installation when an addon EULA is refused
✔️ Public Jenkins job #19 successfully finished |
✔️ Internal Jenkins job #3 successfully finished |
This Fixed in #90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented, the break
introduced here breaks the installer workflow when user is going :back. Fixed in #90.
🚨
Update:
a wrong change introduced here has been fixed in #90. See the comment below📝 Similar to #78, but for
master
(aka SLE-15-SP2)Problem
When user refuses an addon's EULA (doing click in "Next" without check the I Agree to the License Terms.) the installation is completely aborted.
Solution
Show/hide screenshot
The message shown to the user, from an SLE-12 Screenshot (still being the same)
To do that, it has been necessary to update
yast2-packager
too (see yast/yast-packager#456), in order to support "refuse" as a cancel action. Otherwise, it is not possible to distinguish when the "abort" means "to refuse the license agreement" or "abort the installation".Tests