Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release the sources to avoid using up all server connections #82

Merged
merged 1 commit into from Jul 25, 2019
Merged

Release the sources to avoid using up all server connections #82

merged 1 commit into from Jul 25, 2019

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Jul 25, 2019

The Problem

  • When serving the SLE15 modules via a local FTP server AutoYaST gets errors when adding the modules (server timeout errors)
  • See https://bugzilla.suse.com/show_bug.cgi?id=1141127
  • In reality these are "too many connections" errors, the server has a low limit for the maximum number of connections from the same IP

The Solution

  • We need to call the Pkg.SourceReleaseAll call to release the libzypp media accessors

Tests

  • Tested manually with an FTP server configured with max. 3 connections per IP, AutoYaST could add 15 repositories (modules) without any problem.
  • Added an unit test

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 20.163% when pulling 30ccc30 on release_sources into 7f7a95c on master.

@lslezak lslezak mentioned this pull request Jul 25, 2019
Merged
@lslezak lslezak merged commit 85a2ea7 into master Jul 25, 2019
@lslezak lslezak deleted the release_sources branch July 25, 2019 12:51
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #21 successfully finished
✔️ Created OBS submit request #718549

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #5 successfully finished
✔️ Created IBS submit request #197473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lslezak @coveralls @yast-bot @jreidinger