Fix the sub-workflow user input handling #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Reason
Changes made in #78 to not abort the installation when an EULA add-on is refused breaks the sub-workflow without propagating the action first when the user is going :back.
Solution
Propagate the user input properly, without forcing to break the workflow. Actually, it is already being interrupted when the action is :back (among others).
Notes
I was also tempted to improve a little bit the code changing the
if
statement by acase
one, which would allow to include theret = ret2
assignation when theret2 == :back
, reducing the complexity (a little bit).But I discarded the idea since it's out of the scope of this fix.
Test
Tested manually via dud.
Screencast
Click to show/hide a short screencast