Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the sub-workflow user input handling #89

Merged
merged 2 commits into from Nov 22, 2019
Merged

Conversation

dgdavid
Copy link
Member

@dgdavid dgdavid commented Nov 21, 2019

Problem

the installer does not go back beyond the "Add On Product" step

Reason

Changes made in #78 to not abort the installation when an EULA add-on is refused breaks the sub-workflow without propagating the action first when the user is going :back.

Solution

Propagate the user input properly, without forcing to break the workflow. Actually, it is already being interrupted when the action is :back (among others).

Notes

I was also tempted to improve a little bit the code changing the if statement by a case one, which would allow to include the ret = ret2 assignation when the ret2 == :back, reducing the complexity (a little bit).

But I discarded the idea since it's out of the scope of this fix.

Test

Tested manually via dud.

Screencast

Click to show/hide a short screencast

@coveralls
Copy link

Coverage Status

Coverage remained the same at 18.805% when pulling 44a9d5b on fix_add_on_subworkflow into 02a1875 on SLE-15-SP1.

@dgdavid dgdavid changed the title Fix add on subworkflow Fix the sub-workflow user input handling Nov 21, 2019
@dgdavid dgdavid merged commit 52c1a03 into SLE-15-SP1 Nov 22, 2019
@dgdavid dgdavid deleted the fix_add_on_subworkflow branch November 22, 2019 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants