Improved adding add-ons on the Full medium (jsc#SLE-7101) #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
reviewed
Dec 5, 2019
| # | ||
| # Offer the add-ons from the installation medium automatically? | ||
| # The addons are only offered when: | ||
| # - Running in the first stage |
There was a problem hiding this comment.
this is new part of code, it is to avoid calling medium type? Can it happen?
There was a problem hiding this comment.
Yes, that's to avoid querying the medium type in an installed system. I'm not sure, but this code could be also used in an installed system, so just to be sure...
jreidinger
approved these changes
Dec 5, 2019
jreidinger
approved these changes
Dec 6, 2019
|
✔️ Public Jenkins job #30 successfully finished |
|
✔️ Internal Jenkins job #14 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The recent changes enable optional registration also on the Full medium. But we need to avoid mixing the add-ons from SCC (or RMT) with the add-ons from the Full DVD medium. We need to skip the automatic add-ons selection from the medium when the system is registered.
Fix
If the system is registered skip that automatically displayed add-on dialog.