Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not export registered add-ons #99

Merged
merged 4 commits into from Jul 19, 2020
Merged

Conversation

imobachgs
Copy link
Contributor

Trello: https://trello.com/c/jzih5O43/1928-8-export-registered-add-ons-properly
Related to: yast/yast-registration#502

Do not export those add-ons that have been registered. They should be listed in the <suse_register/> section of the profile. This code has been manually tested but it is still a WIP.

* They should liste in the <suse_register/> section.
@coveralls
Copy link

coveralls commented Jul 15, 2020

Coverage Status

Coverage increased (+0.9%) to 23.654% when pulling 223db0d on skip-registered-add-ons into 184ec0e on master.

Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the YaST wrapper.

src/modules/AddOnOthers.rb Outdated Show resolved Hide resolved
@imobachgs imobachgs marked this pull request as ready for review July 17, 2020 10:56
@imobachgs imobachgs changed the title [WIP] Do not export registered add-ons Do not export registered add-ons Jul 17, 2020
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@imobachgs imobachgs merged commit c503f65 into master Jul 19, 2020
@imobachgs imobachgs deleted the skip-registered-add-ons branch July 19, 2020 21:21
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #37 successfully finished
✔️ Created OBS submit request #821773

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants