Removing perl code #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a precursor to use aa-status json profile view. Please note, "Configure" option is left hanging which will be filled in the next patch. Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Handles the profiles using JSON output of aa-status. This replaces the earlier way of handling profiles. Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
jreidinger
reviewed
Jul 27, 2017
src/lib/apparmor/genprof.rb
Outdated
| else | ||
| Yast::Report.Error(_('Unknown Dialog %s returned by apparmor') % hm['dialog']) | ||
| nil | ||
| end |
There was a problem hiding this comment.
just nitpick, but for really big case I prefer map for it like
DIALOG_MAPPING = {
'yesno' => YesNoDialog,
'yesnocancel' => YesNoCancelDialog,
...
}
and usage
dialog = hm['dialog']
dialog_class = DIALOG_MAPPING[dialog]
if dialog_class
dialog_class.new(hm)
else
Yast::Report.Error(_('Unknown Dialog %s returned by apparmor') % hm['dialog'])
nil
end
jreidinger
reviewed
Jul 27, 2017
src/lib/apparmor/logprof.rb
Outdated
| f.puts r.to_json | ||
| f.flush | ||
| end | ||
| end |
There was a problem hiding this comment.
for me this part looks quite similar to GenProf, maybe have common ancestor that share it?
jreidinger
approved these changes
Jul 27, 2017
|
Thanks for the comments. I will incorporate these changes. |
The apparmor_ui_dialog communicates with aa-logprof in JSON. Each dialog is converted to a yast dialog for input from the user and returns the actions performed in yast in the form of JSON response. An extra opendialog has been used to indicate the end of the logprof execution. Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Asks for filename of the program and run aa-genprof --json against the program. Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary reason of this effort is to do away with deprecated apparmor code. Since yast was the major user of the code, we added JSON functionality in apparmor to communicate with yast-apparmor.