Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bsc1172340 #94

Merged
merged 5 commits into from
Apr 5, 2021
Merged

Bsc1172340 #94

merged 5 commits into from
Apr 5, 2021

Conversation

noelpower
Copy link
Collaborator

No description provided.

textdomain "auth"

msg = format(
_("Command line is not supported. Use '%s' directly."),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. I am not sure if ldapkrb and auth-client is CLI tools. You can look for example at storage where is also no suitable CLI tool: https://github.com/yast/yast-storage-ng/pull/1170/files#r527675569

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure I didn't see any existing use of 'CommandLine', whether ldapkrb, auth-client, krb-server or ldap-server should really provide a cli interface is not a question personally I can answer, I am only trying to solve the immediate problem of the bash completion here.

Not really familiar with this stuff so looking at the yast-storage example I am guessing that it is the textdomain & msg/format use here is what you are unhappy about :-)

I'll push a new version with that stuff removed to this & auth-server

mkofahl and others added 5 commits November 25, 2020 08:44
Because of the key "ssl" is set to no|yes|start_tls, the key should be read likewise.
Signed-off-by: Noel Power <noel.power@suse.com>
Signed-off-by: Noel Power <noel.power@suse.com>
Signed-off-by: Noel Power <noel.power@suse.com>
Signed-off-by: Noel Power <noel.power@suse.com>
@scabrero scabrero merged commit e9fd44c into yast:master Apr 5, 2021
@yast-bot
Copy link

yast-bot commented Apr 5, 2021

✔️ Public Jenkins job #22 successfully finished
✔️ Created OBS submit request #883063

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants