Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new krb5 sbin path #65

Merged
merged 3 commits into from
Jul 15, 2020
Merged

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Jul 13, 2020

Problem

The package krb5 was adapted to provide binaries at /usr/sbin path instead of /usr/lib/mit/sbin, see https://build.opensuse.org/request/show/814662.

YaST is still using the old /usr/lib/mit/sbin paths.

Solution

Adapt YaST code to use the new paths.

Note: the changes in the kbr5 package were done without a change in the version number, so yast2-server-auth cannot indicate a conflict with any kbr5 old version. And also note that this new yast2-auth-server package will be submitted to both: SLE-15-SP3 and Factory, but most likely SLE-15-SP3 will not receive any update for kbr5. Because that, yast2-auth-server has to deal with both possible paths (/usr/lib/mit/sbin and /usr/sbin).

Testing

  • Added unit tests.

@joseivanlopez joseivanlopez force-pushed the fix_krb5_path branch 3 times, most recently from 083e993 to d6439b2 Compare July 14, 2020 12:03
@joseivanlopez joseivanlopez marked this pull request as ready for review July 14, 2020 12:44
Copy link
Member

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joseivanlopez joseivanlopez merged commit f612eb8 into yast:master Jul 15, 2020
@yast-bot
Copy link

✔️ Public Jenkins job #11 successfully finished
✔️ Created OBS submit request #821054

@yast-bot
Copy link

✔️ Internal Jenkins job #6 successfully finished
✔️ Created IBS submit request #224067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants