Bug 986049 sp1

[schubi2]

bsc#986049

[mvidner]

OK, so what happens if they are not?

[mvidner]

For reference, the chapter of the manual about scripts: https://www.suse.com/documentation/sles-12/singlehtml/book_autoyast/book_autoyast.html#createprofile.scripts

[mvidner]

I am not sure this is a good approach.

Is the profile actually valid?

It breaks when the profile contains a "script" element containing whitespace:

   <script>
   </script

passing "\n " to Import. When there is <script/>, it is omitted in the imported data and nothing breaks. Maybe we should omit also elements containing only whitespace?

We could also add a custom rescue block inside autoyast around Import calls and report a different message, like:

An error has occurred while importing the profile. Please verify its validity before reporting a bug.

[schubi2]

Well, that's a general problem of AutoYaST. It does not make a semantical check and I do not want to force a xmllint check before parsing because the rng files are so often broken that user will not be amused.
In that case the customer knows that he has a broken AutoYaST file but do not want to fix it.
( I do not know the reason for). As it is a L3 we will handle this case. But there are endless other cases with which crashes are created by using broken AutoYaST configuration files. Currently I do not see a chance to solve this issue in general. I just want to solve this one case :-)

[jreidinger]

@mvidner what is status here? it start rotting

[imobachgs]

@mvidner I guess we could "strip" the string and remove the element if it's empty. But, should it be done while parsing (C++ part or Ruby part) or only while importing the profile? Or maybe you have a better idea...

[mvidner]

Maybe we should omit also elements containing only whitespace?

I have reconsidered, this would be bad for backward compatibility.

We could also add a custom rescue block inside autoyast around Import calls and report a different message

I think this is the way to go. But it does not have to be part of this PR.

So this is OK, once we resolve the merge conflict .

[mvidner]

The Knights of the Chronological Order wouldn't like this. Please use today's date

[mvidner]

LGTM, thank you!