Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report XML errors while reading an AY configuration file #450

Merged
merged 3 commits into from Aug 14, 2018
Merged

Report XML errors while reading an AY configuration file #450

merged 3 commits into from Aug 14, 2018

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented Aug 14, 2018

No description provided.

@schubi2
Report XML errors while reading an
c999e17 
+  AY configuration file
@coveralls
Copy link

coveralls commented Aug 14, 2018 •
edited

Coverage Status

Coverage increased (+0.01%) to 17.316% when pulling c349f00 on SLE-15-GA_bnc_1098794 into 764002f on SLE-15-GA.

imobachgs
imobachgs reviewed Aug 14, 2018
View reviewed changes
src/modules/Profile.rb Outdated Show resolved Hide resolved
@imobachgs
Copy link
Contributor

See https://trello.com/c/ONHPOA1X.

@schubi2
Copy link
Member Author

schubi2 commented Aug 14, 2018

see: https://trello-attachments.s3.amazonaws.com/5b2b92a1265a6fc3b05a7d51/5b36446496c63777ab5f6580/0a0d3cc2a7990cefed63bfc94600b077/ay.png

imobachgs
imobachgs approved these changes Aug 14, 2018
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Perhaps we should explore the new Popup API.

@schubi2
Copy link
Member Author

schubi2 commented Aug 14, 2018

see https://trello-attachments.s3.amazonaws.com/5b2b92a1265a6fc3b05a7d51/5b36446496c63777ab5f6580/c75bdc9bfdd1d451487fb2ad141dfe8e/ay.png

imobachgs
imobachgs approved these changes Aug 14, 2018
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks even better to me :)

@schubi2 schubi2 merged commit a6abd34 into SLE-15-GA Aug 14, 2018
@schubi2 schubi2 deleted the SLE-15-GA_bnc_1098794 branch August 14, 2018 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schubi2 @coveralls @imobachgs