Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize specfile #499

Closed
wants to merge 1 commit into from
Closed

Modernize specfile #499

wants to merge 1 commit into from

Conversation

jengelh
Copy link
Contributor

@jengelh jengelh commented Mar 17, 2019

No description provided.

@coveralls
Copy link

coveralls commented Mar 17, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 17.854% when pulling a6fc47a on jengelh:master into 399e229 on yast:master.

imobachgs
imobachgs reviewed Mar 21, 2019
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks good to me. However, we need to fix the conflict before merging.

Thanks for your contribution!

@jreidinger
Copy link
Member

@jengelh can you please fix that conflict? Thanks

@jengelh
Copy link
Contributor Author

jengelh commented Apr 9, 2019

updated. well, don't let it linger for so long, then there won't be conflicts?

@jreidinger
Copy link
Member

ah, sorry I overlook it again. So this time I solve conflicts. #516
Thanks for contribution.

@jreidinger jreidinger closed this Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jengelh @coveralls @jreidinger @imobachgs