Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLE-15-SP1] Fix the Makefile #594

Merged
merged 2 commits into from Apr 14, 2020
Merged

[SLE-15-SP1] Fix the Makefile #594

merged 2 commits into from Apr 14, 2020

Conversation

dgdavid
Copy link
Member

@dgdavid dgdavid commented Apr 14, 2020 •
edited

Recently, some missing icons were restored (see #585) but the Makefile was not updated with those changes. So, the icons are not available in the final package.

This PR solves the problem.

Related to

Click to show/hide the screenshot
Icons properly shown in SLE-15-SP1 after apply those changes
Screenshot_sle15-sp1_2020-04-14_13:06:05

@dgdavid
Update Makefile
1c9ff61 
To include missing icons reintroduced in commit
9b5f3b3

See #585
@dgdavid
Bump version and update changelog
8e3f3b0
@coveralls
Copy link

Coverage Status

Coverage remained the same at 18.287% when pulling 8e3f3b0 on fix_makefile into 2b3ed89 on SLE-15-SP1.

@dgdavid dgdavid requested a review from imobachgs April 14, 2020 12:15
@dgdavid dgdavid merged commit 2a4af18 into SLE-15-SP1 Apr 14, 2020
@dgdavid dgdavid deleted the fix_makefile branch April 14, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgdavid @coveralls @imobachgs