Use CDATA when serializing the ntp_policy attribute

[teclator]

Problem

As a user I would like to disable the update of the ntp servers through netconfig. That is, I would like to set the netconfig NTP_POLICY as "" (disable) in the AutoYaST profile ntp section.

The problem is that the ntp_policy attribute is empty and it is omitted when serializing the profile at the end of the first stage.

• https://bugzilla.suse.com/show_bug.cgi?id=1172026

Solution

Export ntp_policy via CDATA so that empty strings are preserved for the second stage.

Maybe we should do the same with other netconfig policy options.

Test

• Tested manually

Without the fix the attribute is deleted from the YCP profile

With the fix the attribute contain an empty string in the YCP profile

[coveralls]

Coverage remained the same at 28.236% when pulling 53ffe43 on cdata_ntp_policy into 0fc3470 on SLE-15-SP1.

[mvidner]

The code looks good but the description is confusing. This change tells the Ruby->XML serializer to use CDATA. When I see "permit", that means an option commonly associated with a parser.

Let's call it "Export ntp_policy via CDATA so that empty strings are preserved on Import"

Also, the initial comment of the bug reporter is confusing, they say <ntp_policy><![CDATA[]]></ntp_policy> but the eventually attached xml has <ntp_policy></ntp_policy> so this fix should indeed help.

[teclator]

The code looks good but the description is confusing. This change tells the Ruby->XML serializer to use CDATA. When I see "permit", that means an option commonly associated with a parser.

Let's call it "Export ntp_policy via CDATA so that empty strings are preserved on Import"

Yep you are right, fixing the description. Thnx!!

Also, the initial comment of the bug reporter is confusing, they say <ntp_policy><![CDATA[]]></ntp_policy> but the eventually attached xml has <ntp_policy></ntp_policy> so this fix should indeed help.

Yep, but probably the user tried with both options with the same result.