New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xml exceptions #656
Xml exceptions #656
Conversation
113687b
to
68802bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it looks good. Just a suggestion about the error message.
rescue Yast::XMLSerializationError => e | ||
log.error "Creation of XML failed with #{e.inspect}" | ||
Yast::Popup.Error( | ||
_("Invalid object found when creating XML. Please report a bug.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np: What about a more user friendly message? "Could not create the XML file. Please, report a bug".
✔️ Public Jenkins job #114 successfully finished |
trello: https://trello.com/c/qlBmJwiq/1934-5-handle-new-exceptions-when-serializing-deserializing-xml