Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xml exceptions #656

Merged
merged 11 commits into from Jul 23, 2020
Merged

Xml exceptions #656

merged 11 commits into from Jul 23, 2020

Conversation

jreidinger
Copy link
Member

@coveralls
Copy link

coveralls commented Jul 21, 2020

Coverage Status

Coverage increased (+0.8%) to 56.894% when pulling d022b2c on xml_exceptions into b703a05 on master.

@jreidinger jreidinger marked this pull request as ready for review July 23, 2020 09:59
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, it looks good. Just a suggestion about the error message.

rescue Yast::XMLSerializationError => e
log.error "Creation of XML failed with #{e.inspect}"
Yast::Popup.Error(
_("Invalid object found when creating XML. Please report a bug.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np: What about a more user friendly message? "Could not create the XML file. Please, report a bug".

@jreidinger jreidinger merged commit 94cd6e4 into master Jul 23, 2020
@jreidinger jreidinger deleted the xml_exceptions branch July 23, 2020 11:16
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #114 successfully finished
✔️ Created OBS submit request #822367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants