Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ask selection #743

Merged
merged 3 commits into from Mar 17, 2021
Merged

Fix ask selection #743

merged 3 commits into from Mar 17, 2021

Conversation

jreidinger
Copy link
Member

@coveralls
Copy link

coveralls commented Mar 17, 2021 •
edited

Coverage Status

Coverage remained the same at 63.96% when pulling e932182 on fix_ask_selection into f448b4e on master.

imobachgs
imobachgs approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor comment.

src/include/autoinstall/xml.rb Outdated Show resolved Hide resolved
@jreidinger jreidinger merged commit 2a3493b into master Mar 17, 2021
@jreidinger jreidinger deleted the fix_ask_selection branch March 17, 2021 12:48
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #180 successfully finished
✔️ Created OBS submit request #879683

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #106 successfully finished
✔️ Created IBS submit request #238100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jreidinger @coveralls @yast-bot @imobachgs