Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test Stage mocking #814

Merged
merged 1 commit into from Dec 3, 2021
Merged

Fix unit test Stage mocking #814

merged 1 commit into from Dec 3, 2021

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Dec 3, 2021

Fix for failing build:

[  122s] 
[  122s]   1) Y2Autoinstallation::EFIDetector.boot_efi? when called in normal Mode returns true if '/sys/firmware/efi/efivars' exists
[  122s]      Failure/Error: expect(described_class.boot_efi?).to eq(true)
[  122s] 
[  122s]        expected: true
[  122s]             got: false
[  122s] 
[  122s]        (compared using ==)
[  122s] 
[  122s]        Diff:
[  122s]        @@ -1,2 +1,2 @@
[  122s]        -true
[  122s]        +false
[  122s]      # ./test/lib/efi_detector_test.rb:36:in `block (5 levels) in <top (required)>'
[  122s] 
[  122s]   2) Y2Autoinstallation::EFIDetector.boot_efi? when called in normal Mode returns true if '/sys/firmware/efi/vars/' exists
[  122s]      Failure/Error: expect(described_class.boot_efi?).to eq(true)
[  122s] 
[  122s]        expected: true
[  122s]             got: false
[  122s] 
[  122s]        (compared using ==)
[  122s] 
[  122s]        Diff:
[  122s]        @@ -1,2 +1,2 @@
[  122s]        -true
[  122s]        +false
[  122s]      # ./test/lib/efi_detector_test.rb:36:in `block (5 levels) in <top (required)>'

https://build.suse.de/package/live_build_log/Devel:YaST:Head/autoyast2/SUSE_SLE-15-SP4_GA/x86_64

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.048% when pulling 97188f4 on fix_unit_test_mocking into 8846b15 on master.

@teclator teclator merged commit af17161 into master Dec 3, 2021
@teclator teclator deleted the fix_unit_test_mocking branch December 3, 2021 14:47
@yast-bot
Copy link
Contributor

yast-bot commented Dec 3, 2021

✔️ Public Jenkins job #216 successfully finished

@yast-bot
Copy link
Contributor

yast-bot commented Dec 3, 2021

✔️ Internal Jenkins job #128 successfully finished
✔️ Created IBS submit request #259707

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants