Replace PackageAI with Package references
#820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* They are not used in any YaST module.
imobachgs
force-pushed
the
unify-package-rb
branch
from
3c5ac40
to
1964681
Compare
jreidinger
reviewed
Jan 21, 2022
| @@ -151,12 +151,14 @@ def Import(settings) | |||
| to: "list <string>" | |||
| ) | |||
|
|
|||
| PackageAI.toinstall = settings.fetch("packages", []) | |||
| to_install = settings.fetch("packages", []) | |||
| PackagesProposal.AddResolvables("autoyast", :package, to_install) unless to_install.empty? | |||
There was a problem hiding this comment.
Is it AddResolvables or SetResolvables? Is expected to have more there?
There was a problem hiding this comment.
I preferred to be conservative and use AddResolvables, just in case for some reason we add more packages from a different place. In that case, the selection would be lost.
jreidinger
reviewed
Jan 21, 2022
| @kernel = settings.fetch("kernel", "") | ||
|
|
||
| addPostPackages(settings.fetch("post-packages", [])) | ||
| AutoinstData.post_patterns = settings.fetch("post-patterns", []) | ||
| PackageAI.toremove = settings.fetch("remove-packages", []) | ||
| to_remove = settings.fetch("remove-packages", []) | ||
| PackagesProposal.AddTaboos("autoyast", :package, to_remove) unless to_remove.empty? |
There was a problem hiding this comment.
Same than above :-)
|
✔️ Public Jenkins job #222 successfully finished |
|
✔️ Internal Jenkins job #134 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt AutoYaST to do not use the
PackageAImodule anymore. It should use the genericPackageinstead. See yast/yast-yast2#1219.NOTE: tests are expected to fail until the yast/yast-yast2#1219 is merged.