explain when nil can be returned

yast · Apr 6, 2016 · 1aaeaf4 · 1aaeaf4
1 parent 941e3af
commit 1aaeaf4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/lib/bootloader/sections.rb b/src/lib/bootloader/sections.rb
@@ -22,6 +22,8 @@ def default
 
       return @default = "" if Yast::Stage.initial
 
+      # Execute.on_target can return nil if call failed. It shows users error popup, but bootloader
+      # can continue with empty default section
       saved = Yast::Execute.on_target("/usr/bin/grub2-editenv", "list", stdout: :capture) || ""
       saved_line = saved.lines.grep(/saved_entry=/).first
 

diff --git a/test/grub2base_test.rb b/test/grub2base_test.rb
@@ -357,6 +357,7 @@
     end
 
     before do
+      allow(Yast::Execute).to receive(:on_target).and_return("")
       subject.define_singleton_method(:name) { "grub2base" }
     end