Skip to content

Commit

Permalink
mark properly configuration as read and remove not used parameters (b…
Browse files Browse the repository at this point in the history
…nc#978366)
  • Loading branch information
jreidinger committed May 16, 2016
1 parent d477eae commit 8408fa0
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 11 deletions.
7 changes: 3 additions & 4 deletions src/lib/bootloader/grub2.rb
Expand Up @@ -30,9 +30,8 @@ def initialize
@trusted_boot = false
end

# Read settings from disk
# @param [Boolean] reread boolean true to force reread settings from system
def read(reread: false)
# Read settings from disk, overwritting already set values
def read
super

begin
Expand All @@ -54,7 +53,7 @@ def read(reread: false)
@device_map = DeviceMap.new
end

@trusted_boot = Sysconfig.from_system.trusted_boot if reread || @trusted_boot.nil?
@trusted_boot = Sysconfig.from_system.trusted_boot
end

# Write bootloader settings to disk
Expand Down
6 changes: 4 additions & 2 deletions src/lib/bootloader/grub2base.rb
Expand Up @@ -70,8 +70,10 @@ def pmbr_setup(*devices)
end
end

def read(reread: false)
grub_default.load if !grub_default.loaded? || reread
def read
super

grub_default.load
grub_cfg = CFA::Grub2::GrubCfg.new
begin
grub_cfg.load
Expand Down
8 changes: 3 additions & 5 deletions src/lib/bootloader/grub2efi.rb
Expand Up @@ -21,11 +21,9 @@ def initialize
@grub_install = GrubInstall.new(efi: true)
end

# Read settings from disk
# @param [Boolean] reread boolean true to force reread settings from system
# internal data
def read(reread: false)
@secure_boot = Sysconfig.from_system.secure_boot if reread || @secure_boot.nil?
# Read settings from disk overwritting already set values
def read
@secure_boot = Sysconfig.from_system.secure_boot

super
end
Expand Down

0 comments on commit 8408fa0

Please sign in to comment.