Skip to content

Commit

Permalink
make rubocop happy
Browse files Browse the repository at this point in the history
  • Loading branch information
jreidinger committed Nov 18, 2015
1 parent f30c7d7 commit bedfa3e
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 25 deletions.
14 changes: 6 additions & 8 deletions src/include/bootloader/grub2/options.rb
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,7 @@ def ConsoleStore(_widget, _event)
use_serial = UI.QueryWidget(Id(:console_frame), :Value)
use_gfxterm = UI.QueryWidget(Id(:gfxterm_frame), :Value)

if use_gfxterm && use_serial
use_gfxterm = false
end
use_gfxterm = false if use_gfxterm && use_serial

if use_serial
console_value = UI.QueryWidget(Id(:console_args), :Value)
Expand Down Expand Up @@ -361,11 +359,11 @@ def Grub2Options
"store" => fun_ref(method(:store_os_prober), "void (string, map)")
},
"append" => {
"widget"=> :textentry,
"label" => @grub2_descriptions["append"],
"help" => @grub2_help_messages["append"],
"init" => fun_ref(method(:init_append), "void (string)"),
"store" => fun_ref(method(:store_append), "void (string, map)")
"widget" => :textentry,
"label" => @grub2_descriptions["append"],
"help" => @grub2_help_messages["append"],
"init" => fun_ref(method(:init_append), "void (string)"),
"store" => fun_ref(method(:store_append), "void (string, map)")
},
"vgamode" => {
"widget" => :combobox,
Expand Down
29 changes: 14 additions & 15 deletions src/lib/bootloader/grub2base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ def pmbr_setup(action, *devices)
# Propose global options of bootloader
def StandardGlobals
{
"default" => "0",
"vgamode" => "",
"gfxmode" => "auto",
"activate" => Arch.ppc ? "true" : "false"
"default" => "0",
"vgamode" => "",
"gfxmode" => "auto",
"activate" => Arch.ppc ? "true" : "false"
}
end

Expand Down Expand Up @@ -181,16 +181,16 @@ def serial_console_matcher

def propose_os_probing
os_prober = grub_default.os_prober
if !os_prober.defined?
# s390 do not have os_prober, see bnc#868909#c2
# ppc have slow os_prober, see boo#931653
disable_os_prober = (Arch.s390 || Arch.ppc) ||
ProductFeatures.GetBooleanFeature("globals", "disable_os_prober")
if disable_os_prober
os_prober.disable
else
os_prober.enable
end
return if os_prober.defined?

# s390 do not have os_prober, see bnc#868909#c2
# ppc have slow os_prober, see boo#931653
disable_os_prober = (Arch.s390 || Arch.ppc) ||
ProductFeatures.GetBooleanFeature("globals", "disable_os_prober")
if disable_os_prober
os_prober.disable
else
os_prober.enable
end
end

Expand All @@ -212,6 +212,5 @@ def propose_serial

grub_default.serial_console = console.console_args
end

end
end
4 changes: 2 additions & 2 deletions src/lib/bootloader/serial_console.rb
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@ def self.load_from_console_args(console_args)
new(unit, speed, parity, word)
end

def initialize(unit, speed=SPEED_DEFAULT, parity=PARITY_DEFAULT,
word=WORD_DEFAULT)
def initialize(unit, speed = SPEED_DEFAULT, parity = PARITY_DEFAULT,
word = WORD_DEFAULT)
@unit = unit
@speed = speed
@parity = parity
Expand Down

0 comments on commit bedfa3e

Please sign in to comment.