Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-Authored-By: jreidinger <jreidinger@suse.cz>
  • Loading branch information
lslezak and jreidinger committed Feb 28, 2019
1 parent 3528df4 commit d0a2ca1
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
6 changes: 3 additions & 3 deletions src/lib/bootloader/generic_widgets.rb
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ def handle
def help
_(
"<p><b>Boot Loader</b>\n" \
"specifies which bootloader to install. Can be also specified <tt>None</tt> " \
"which mean that bootloader configuration is not managed by YaST2 and also " \
"kernel post install script does not update bootloader configuration."
"specifies which bootloader to install. Can be also set to <tt>None</tt> " \
"which means that the boot loader configuration is not managed by YaST and also " \
"the kernel post install script does not update the boot loader configuration."
)
end
end
Expand Down
14 changes: 7 additions & 7 deletions src/lib/bootloader/grub2_widgets.rb
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def label
def help
_(
"<p><b>Set active Flag in Partition Table for Boot Partition</b>\n" \
"specify if the partition which contains the boot loader will have active flag." \
"specify whether the partition containing the boot loader will have active flag." \
" The generic MBR code will then\n" \
"boot the active partition. Older BIOSes require one partition to be active even\n" \
"if the boot loader is installed in the MBR.</p>"
Expand Down Expand Up @@ -272,7 +272,7 @@ def label
end

def help
_("<p><b>Enable Secure Boot Support</b> if checked enable UEFI Secure Boot.</p>")
_("<p><b>Enable Secure Boot Support</b> if checked enables UEFI Secure Boot support.</p>")
end

def init
Expand Down Expand Up @@ -305,10 +305,10 @@ def help
"chip).\n")
if grub2.name == "grub2"
res += _(" First you need to make sure Trusted Boot is enabled in the BIOS\n" \
"setup (the setting may be named Security Chip, for example).\n")
"setup (the setting may be named \"Security Chip\", for example).\n")
end

res += "<p>"
res += "</p>"

res
end
Expand Down Expand Up @@ -480,8 +480,8 @@ def help
"<p><b>Use graphical console</b> when checked it allows to use various " \
"display resolutions. The <tt>auto</tt> option tries to find " \
"the best one when booting starts.</p>\n" \
"<p><b>Use serial console</b> when checked it redirect the boot output " \
"a serial device like <tt>ttyS0</tt>. " \
"<p><b>Use serial console</b> when checked it redirects the boot output " \
"to a serial device like <tt>ttyS0</tt>. " \
"At least the <tt>--unit</tt> option has to be specified, " \
"and the complete syntax is <tt>%s</tt>. " \
"Other parts are optional and if not set, a default is used. " \
Expand Down Expand Up @@ -673,7 +673,7 @@ def label

def help
_(
"<p><b>Default Boot Section</b> selects boot section to be booted as default.\n" \
"<p><b>Default Boot Section</b> selects the default section for booting.\n" \
" If YaST2 does not know yet naming of sections, it will be empty and default \n" \
"is let on grub2 itself.</p>" \
)
Expand Down
2 changes: 1 addition & 1 deletion test/boot_storage_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
)
end

it "returns only mounted swaps if it is available" do
it "returns only mounted swaps if any is available" do
devicegraph_stub("multi_swap.yaml")
expect(subject.available_swap_partitions).to eq(
"/dev/sdb2" => 1_026_048
Expand Down

0 comments on commit d0a2ca1

Please sign in to comment.