Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ppc install #222

Merged
merged 2 commits into from Feb 18, 2015
Merged

Fix ppc install #222

merged 2 commits into from Feb 18, 2015

Conversation

jreidinger
Copy link
Member

No description provided.

@jreidinger
Copy link
Member Author

verified in real installation on ppc

@ancorgs
Copy link
Contributor

ancorgs commented Feb 18, 2015

Just wondering if the change would not affect nfs installation. I have not gone through BootCommon code, I just worry that not calling BootCommon.DetectDisks can alter the result of BootCommon.getBootDisk. If it's not the case (once again, I have not looked at it so I trust you), LGTM.

@jreidinger
Copy link
Member Author

@ancor BootCommon.DetectDisks call this detect_disks and then if needed repropose configuration location. but getBootDisk is set by detect_disks

jreidinger added a commit that referenced this pull request Feb 18, 2015
@jreidinger
Merge pull request #222 from yast/fix_ppc_install
cbbe422 
Fix ppc install
@jreidinger jreidinger merged commit cbbe422 into master Feb 18, 2015
@jreidinger jreidinger deleted the fix_ppc_install branch February 18, 2015 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jreidinger @ancorgs