Correct boot flag #245
Merged
Correct boot flag #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,11 @@ | |||
| ------------------------------------------------------------------- | |||
| Mon Jun 29 12:46:58 UTC 2015 - jreidinger@suse.com | |||
|
|
|||
| - set only proper boot boot flags, otherwise it can confuse some | |||
There was a problem hiding this comment.
yep, thanks for catch
There was a problem hiding this comment.
The term proper boot flags is a bit vague, could you be more specific if possible?
There was a problem hiding this comment.
Exactly. I see that the bug report does not help much because you wrote it yourself :) but please try a user's perspective: if the old code failed, the circumstances and symptoms would be such and such. Probably include "Distinguish between MSDOS and GPT tables when setting boot flags" ?
|
The code looks good (but maybe I change my mind after you fix the description ;-) ) OTOH, Rubocop has no feelings: "Class definition is too long. [179/176]" |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.