Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit AY settings #403

Merged
merged 3 commits into from
Jan 10, 2017
Merged

Edit AY settings #403

merged 3 commits into from
Jan 10, 2017

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented Jan 10, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 69.421% when pulling 683d5c0 on SLE-12-SP1_bnc_1018180 into b7b52e7 on SLE-12-SP1.

jreidinger
jreidinger approved these changes Jan 10, 2017
View reviewed changes
Copy link
Member

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sense

jreidinger
jreidinger requested changes Jan 10, 2017
View reviewed changes
src/lib/bootloader/device_map.rb
if !Yast::Arch.ppc
return to_hash if Yast::Storage.GetDefaultMountBy == :label
if Yast::Mode.config || # AutoYaST configuration mode --> no Storage available
!Arch.ppc && Storage.GetDefaultMountBy == :label
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, it have to be Yast::Arch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and also Yast::Storage as device map do not live in yast namespace

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 69.421% when pulling 3209adb on SLE-12-SP1_bnc_1018180 into b7b52e7 on SLE-12-SP1.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 69.505% when pulling 9442a9f on SLE-12-SP1_bnc_1018180 into b7b52e7 on SLE-12-SP1.

@jreidinger
Copy link
Member

LGTM

@schubi2 schubi2 merged commit 8664d87 into SLE-12-SP1 Jan 10, 2017
@shundhammer shundhammer deleted the SLE-12-SP1_bnc_1018180 branch March 28, 2019 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schubi2 @coveralls @jreidinger