Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared RSpec examples for CWM widgets #414

Merged
merged 7 commits into from Aug 9, 2017
Merged

Use shared RSpec examples for CWM widgets #414

merged 7 commits into from Aug 9, 2017

Conversation

mvidner
Copy link
Member

@mvidner mvidner commented Mar 20, 2017

No description provided.

@mvidner
Copy link
Member Author

mvidner commented Mar 20, 2017

Using yast/yast-yast2#555

@coveralls
Copy link

Coverage Status

Coverage decreased (-49.8%) to 30.665% when pulling 24ff6f3 on cwm-rspec into 7093dcd on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 82.61% when pulling 02d180b on cwm-rspec into 7093dcd on master.

@mvidner
Copy link
Member Author

mvidner commented Mar 20, 2017

Ugh, in Travis I get a ExpiredTestDoubleError and I have no idea how that appears.

@jreidinger
Copy link
Member

@mvidner my idea is that widget need to return some value some mocking and it is missing there, and instead double from other test is used. Btw see my LabeledWidget shared example which looks similar to your attempt.

@jreidinger
Copy link
Member

yast2 already have rspec test, can you please rebase it? then I will merge it.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.002%) to 82.694% when pulling d9073a4 on cwm-rspec into 3a1dba4 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.002%) to 82.694% when pulling 0c5bff2 on cwm-rspec into 3a1dba4 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.7%) to 82.441% when pulling 0300647 on cwm-rspec into 3a1dba4 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 82.884% when pulling 99b4433 on cwm-rspec into 3a1dba4 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 82.884% when pulling 1f636b6 on cwm-rspec into 3a1dba4 on master.

Copy link
Member

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it looks in good shape for me

@mvidner mvidner merged commit 9a9255a into master Aug 9, 2017
@mvidner mvidner deleted the cwm-rspec branch August 9, 2017 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants