bsc#1039712 and bsc#1052006: Find correct mbr device to install grub #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shundhammer
reviewed
Aug 22, 2017
| ) | ||
| boot_disk = Yast::Storage.GetDisk(tm, dev)["device"] |
There was a problem hiding this comment.
I just tried to understand that Storage.GetDisk() function and Storage.GetDiskPartitionTg() which it calls. The latter function seems to take the partition name and from that tries to deduce the disk name, then searching the target map for a disk that also has that partition as a child. It also does not check the type of the object (it should test for CT_DISK), so it seems to work only because the names don't match otherwise (or it might find the CT_BTRFS container for /dev/btrfs as well as in the bug that this patch is about to fix).
So this does work, but entirely for the wrong reasons (which is the fault of that old storage code, not of your patch).
shundhammer
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.