Install grub2 into boot_prep device #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -606,6 +606,7 @@ def InitBootLoaderLocationWidget(widget) | |||
| "boot_mbr", | |||
| "boot_boot", | |||
| "boot_root", | |||
| "boot_prep", | |||
There was a problem hiding this comment.
in general I don't think that this is good idea as it is not unique identifier as there can be more then one prep partition
Those changes brought PowerPC specific grub2 installation into PReP device. Tested on local disk only. Signed-off-by: Dinar Valeev <dvaleev@suse.com>
|
closing this pull request as we use different approach to implement this ability |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those changes brought PowerPC specific grub2 installation into PReP
device.
Tested on local disk only.
Signed-off-by: Dinar Valeev dvaleev@suse.com