Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Enable secureboot on aarch64 (boo#1136601) #565

Merged
merged 1 commit into from Jun 6, 2019
Merged

[RFC] Enable secureboot on aarch64 (boo#1136601) #565

merged 1 commit into from Jun 6, 2019

Conversation

ggardet
Copy link
Contributor

@ggardet ggardet commented May 28, 2019 •
edited by mvidner

@ggardet ggardet mentioned this pull request May 28, 2019
Closed
mvidner
mvidner reviewed May 29, 2019
View reviewed changes
Copy link
Member

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
@jreidinger can you please check the reported bug too?

src/lib/bootloader/grub_install.rb Outdated Show resolved Hide resolved
@jreidinger
Copy link
Member

@afaerber Can you please check it as arm expert if it is reasonable approach?

@coveralls
Copy link

coveralls commented May 29, 2019 •
edited

Coverage Status

Coverage increased (+0.005%) to 83.404% when pulling 764e837 on ggardet:master into 4b37dc0 on yast:master.

@jreidinger
Copy link
Member

in general look good here. I just need to wait till new grub2 reaches TW as we need to send it together.

@afaerber
Copy link
Contributor

afaerber commented Jun 5, 2019

@jreidinger The logic changes look good to me (we may want to extend the architecture list later for 32-bit or other non-x86 archs, this becomes easier now), and the grub2-install approach was the requested one by the team. There were discussions to use that also for x86 as a wrapper for consistency, but changes can always be done incrementally. Can't fully review the Ruby code myself.

@jreidinger
Copy link
Member

@afaerber thanks for info. Ruby code looks good. So now I am just waiting till modified grub will be send to factory.

@jreidinger jreidinger merged commit 8550ef8 into yast:master Jun 6, 2019
@yast-bot
Copy link
Contributor

yast-bot commented Jun 6, 2019

✔️ Public Jenkins job #29 successfully finished
✔️ Created OBS submit request #708010

@yast-bot
Copy link
Contributor

❌ Internal Jenkins job #1 failed

@yast-bot
Copy link
Contributor

❌ Internal Jenkins job #2 failed

@yast-bot
Copy link
Contributor

❌ Internal Jenkins job #3 failed

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #4 successfully finished
✔️ Created IBS submit request #195572

@dgdavid dgdavid mentioned this pull request Aug 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvidner mvidner mvidner left review comments

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ggardet @jreidinger @coveralls @afaerber @yast-bot @mvidner