New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort the module execution when running w/o enough privileges #583

Merged

dgdavid merged 6 commits into master from check_privileges

Nov 27, 2019

Commits on Nov 25, 2019

Add an exception for the lack of enough privileges

dgdavid committed Nov 25, 2019

Copy the full SHA

6b1efeb View commit details

Browse the repository at this point in the history
Raise a Bootloader::InsufficientPrivileges exception
```
When catch an Errno::EACCES trying to read the grub.cfg file.
```
dgdavid committed Nov 25, 2019
Copy the full SHA

2606c38 View commit details

Browse the repository at this point in the history
Abort the module execution when not enough privileges

dgdavid committed Nov 25, 2019

Copy the full SHA

3701667 View commit details

Browse the repository at this point in the history

Commits on Nov 26, 2019

Do not use a custom exception for insufficient priveleges
```
Based on a code review comment:

  https://github.com/yast/yast-bootloader/pull/583/files#r350677467

Basically, catch the Errno:EACCES exception direclty in Bootloader.Read
```
dgdavid committed Nov 26, 2019
Copy the full SHA

1f45550 View commit details

Browse the repository at this point in the history
Update version and changelog

dgdavid committed Nov 26, 2019

Copy the full SHA

22af92e View commit details

Browse the repository at this point in the history
Add explanatory comment
```
Suggested during the review.

See #583 (comment)
```
dgdavid committed Nov 26, 2019
Copy the full SHA

cf778fa View commit details

Browse the repository at this point in the history