Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoYaST: Added supplements: autoyast(bootloader) into the spec file … #613

Merged
merged 1 commit into from Aug 12, 2020
Merged

AutoYaST: Added supplements: autoyast(bootloader) into the spec file … #613

merged 1 commit into from Aug 12, 2020

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented Aug 11, 2020

…in order to install this packages if the section has been defined in the AY configuration file (bsc#1146494).

@schubi2
AutoYaST: Added supplements: autoyast(bootloader) into the spec file …
ac7db22 
…in order to install this packages if the section has been defined in the AY configuration file (bsc#1146494).
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.547% when pulling ac7db22 on master-bsc-1146494 into 58e9743 on master.

lslezak
lslezak approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lslezak
lslezak requested changes Aug 12, 2020
View reviewed changes
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bootloader is installed in the first stage, I think we do not need this...

lslezak
lslezak approved these changes Aug 12, 2020
View reviewed changes
Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as discussed let's add it everywhere and the logic should decide how to handle it.

@lslezak lslezak merged commit 663f1ea into master Aug 12, 2020
@lslezak lslezak deleted the master-bsc-1146494 branch August 12, 2020 11:54
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #61 successfully finished
✔️ Created OBS submit request #826026

@yast-bot
Copy link
Contributor

❌ Internal Jenkins job #29 failed

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #30 successfully finished
✔️ Created IBS submit request #224301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lslezak lslezak lslezak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@schubi2 @coveralls @yast-bot @lslezak