New rubocop #660
Merged
New rubocop #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lslezak
reviewed
Jan 6, 2022
src/lib/bootloader/grub2base.rb
Outdated
| "<a href=\"enable_secure_boot\">(#{_("enable")})</a>" | ||
| end | ||
|
|
||
| "#{_("Secure Boot:")} #{secure_boot ? _("enabled") : _("disabled")} #{link}" |
There was a problem hiding this comment.
NP: this pattern is repeated several times in the code, what about defining some helper like
def status_string(status)
status ? _("enabled") : _("disabled")
end
# and then use in
"#{_("Secure Boot:")} #{status_string(secure_boot)} #{link}"
test/grub2pwd_test.rb
Outdated
| @@ -5,6 +5,23 @@ | |||
|
|
|||
| require "bootloader/grub2pwd" | |||
|
|
|||
| ENCRYPTED_PASSWORD = "grub.pbkdf2.sha512.10000.774E325959D6D7BCFB7384A0245674D83D0D540A89C02FEA81E35489F8DE7ADFD93988190AD9857A0FFF363825DDF97C8F4E658D8CC49FC4A22C053B08AB3EFE.6FB19FF26FD03D85C40A33D8BA7C04E72EDE3DD5D7080C177553A4FED370F71C579AF0B15B3B93ECECEA355469A4B6D0560BFB53ED35DDA0B80F5363BFBD54E4" | |||
There was a problem hiding this comment.
strange that it does not complain. Not sure why
jreidinger
commented
Jan 6, 2022
src/lib/bootloader/sysconfig.rb
Outdated
| @@ -35,14 +35,14 @@ def initialize(bootloader: nil, secure_boot: false, trusted_boot: false, update_ | |||
| end | |||
|
|
|||
| def self.from_system | |||
| bootloader = Yast::SCR.Read(AGENT_PATH + "LOADER_TYPE") | |||
| bootloader = Yast::SCR.Read("#{AGENT_PATH}LOADER_TYPE") | |||
There was a problem hiding this comment.
and here is wrong auto correct. Because AGENT_PATH is not string, but Yast::Path, then result is different.
|
It LGTM but maybe @dgdavid found something I overlooked 😜 |
dgdavid
reviewed
Jan 12, 2022
dgdavid
reviewed
Jan 12, 2022
Comment on lines
+453
to
+457
| if status | ||
| _("enabled") | ||
| else | ||
| _("disabled") | ||
| end |
There was a problem hiding this comment.
NP: I'd use ternary operator here.
|
✔️ Internal Jenkins job #67 successfully finished |
|
✔️ Public Jenkins job #104 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
draft for review of changes done in new rubocop that works with ruby 3.1