Fix migration sp5 #684
Merged
Fix migration sp5 #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shundhammer
reviewed
Apr 26, 2023
| @@ -226,7 +226,8 @@ def propose_for_update(force_reset) | |||
| # old one is grub2, but mismatch of EFI and non-EFI (bsc#1081355) | |||
| elsif old_bootloader =~ /grub2/ && old_bootloader != current_bl.name | |||
| raise MismatchBootloader.new(old_bootloader, current_bl.name) | |||
| elsif !current_bl.proposed? || force_reset | |||
| elsif force_reset | |||
| log.warn "forced proposel during migration. Will change existing config" | |||
There was a problem hiding this comment.
Typo: s/proposel/proposal/
Are we also going to tell the user about this forced reset?
|
✔️ Internal Jenkins job #754 successfully finished |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
User selection was ignored during migration.
Solution
Drop legacy code for SLE11 migration and reset proposal only if it is forced.
Testing