Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve warning for secure boot on s390 to reflect changes done on ha… #696

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

jreidinger
Copy link
Member

…rdware side (bsc#1219989)

Problem

Hardware start supporting more disk types for secure boot on s390, so warning is no longer accurate.

Solution

Try to improve warning text and also help text to be more accurate.

@coveralls
Copy link

coveralls commented Mar 7, 2024

Coverage Status

coverage: 88.092%. remained the same
when pulling eb6688f on update_s390_warning
into a964b05 on SLE-15-SP6.

@jreidinger jreidinger marked this pull request as ready for review March 15, 2024 10:14
src/lib/bootloader/grub2_widgets.rb Outdated Show resolved Hide resolved
src/lib/bootloader/grub2_widgets.rb Outdated Show resolved Hide resolved
Co-authored-by: Martin Vidner <martin@vidner.net>
Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreidinger jreidinger merged commit 5940ab8 into SLE-15-SP6 Mar 15, 2024
12 checks passed
@jreidinger jreidinger deleted the update_s390_warning branch March 15, 2024 13:06
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #4 successfully finished
✔️ Created IBS submit request #324131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants