Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move specific YaST code from yast-installation #12

Merged
merged 6 commits into from
Apr 28, 2017

Conversation

imobachgs
Copy link
Contributor

No description provided.

* Some cops are disabled for the inst_casp_overview client.
@coveralls
Copy link

Coverage Status

Coverage increased (+3.5%) to 90.196% when pulling d8c7878 on move-from-yast-installation into 19ebadc on master.

include Yast::I18n
include Yast::UIShortcuts

def run # rubocop:disable MethodLength, AbcSize, CyclomaticComplexity, PerceivedComplexity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better then disable is to specify current values, so no regression can happen

Copy link
Member

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+3.5%) to 90.196% when pulling 7f77d65 on move-from-yast-installation into 19ebadc on master.

@imobachgs imobachgs merged commit 964afad into master Apr 28, 2017
@jreidinger jreidinger deleted the move-from-yast-installation branch September 6, 2017 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants