Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Mirror configuration #39

Closed
wants to merge 3 commits into from

Conversation

bergmannf
Copy link

Allows to setup a mirror for the container runtime during installation.

The mirror will be used as a fallback to download images that can't be found on the initially used registry.

@bergmannf bergmannf force-pushed the mirror_configuration branch 4 times, most recently from 2bc26b6 to d8c52ff Compare December 11, 2018 17:18
@coveralls
Copy link

coveralls commented Dec 11, 2018

Coverage Status

Coverage increased (+0.8%) to 90.82% when pulling c66feff on bergmannf:mirror_configuration into 28e3023 on yast:master.

@bergmannf bergmannf force-pushed the mirror_configuration branch 18 times, most recently from dbc600e to 19d3c9e Compare January 8, 2019 13:09
@bergmannf bergmannf force-pushed the mirror_configuration branch 7 times, most recently from b54636a to 5625562 Compare January 17, 2019 14:03
@bergmannf bergmannf force-pushed the mirror_configuration branch 3 times, most recently from 48e966e to 1e43120 Compare January 18, 2019 10:15
@bergmannf bergmannf changed the title [WIP] Mirror configuration Allow Mirror configuration Jan 18, 2019
@bergmannf bergmannf force-pushed the mirror_configuration branch 5 times, most recently from 0854988 to c3417b8 Compare January 21, 2019 10:37
This feature is only applicable for SLE15 based CaaSP installations, as those
will no longer use container-feeder, but download the docker images from a
registry instead.

By default this registry will be the official suse registry (registry.suse.com),
but the customer always has the possibility to mirror it, in which case he can
then set this mirror during installation.

This mirror will then be used a fallback, if the official registry can not be
reached.

When the user enters a https:// mirror, the certificate can be verified by
supplying a fingerprint (SHA1).
Initially this mean all the mirror related configuration will be disabled.
@bergmannf bergmannf force-pushed the mirror_configuration branch 8 times, most recently from be0df2d to 69ba939 Compare January 22, 2019 14:48
@bergmannf
Copy link
Author

I think this is now finally ready for review! Here is a screenshot of the new dialog to allow setting up a mirror:
screenshot_20190123_110709

@jreidinger
Copy link
Member

asked @sysrich to review it function wise and if it is approved, I will merge PR mergable and do it.

@sysrich
Copy link

sysrich commented Oct 2, 2020

Why.. i don’t have anything to do with any product that uses the SUSE container registry...

@jreidinger
Copy link
Member

ah, it is caasp only role, not kubic one. So @thkukuk probably something for you?

@thkukuk
Copy link
Contributor

thkukuk commented Oct 5, 2020

I have nothing to do anymore with CaaSP and if I understand the pull request correct, this will not infect openSUSE [Kubic|MicroOS] or SUSE MicroOS. So nothing I can add.
But for what is this? The CaaSP Code isn't in use anymore and to my knowledge it will not work with CaaSP v4.x.
And since the pull request is nearly two years old, is it still valid at all?

@jreidinger
Copy link
Member

@bergmannf we are going through all pull request and want to ask if this one is still valid? if not, feel free to close it. Otherwise please clarify its intention. Thanks

@bergmannf
Copy link
Author

As noone picked this up and I can no longer access SLE internals anyhow to see if it works for Caasp, I'll close it.

@bergmannf bergmannf closed this Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants