Fix client mode and clean-up #5
Conversation
* It is not needed anymore because all happens now during the 1st stage.
* When configuring or running the provisioners, it should use the "chrooted" path.
imobachgs
force-pushed
the
merge-minion-config
branch
from
5540b4a
to
68c933a
Compare
* This code is not used anymore.
* It is not needed anymore.
imobachgs
force-pushed
the
merge-minion-config
branch
from
68c933a
to
454b63f
Compare
|
Changes Unknown when pulling 454b63f on merge-minion-config into ** on master**. |
imobachgs
force-pushed
the
merge-minion-config
branch
from
8232bd2
to
bd7c84d
Compare
imobachgs
force-pushed
the
merge-minion-config
branch
from
bd7c84d
to
328120a
Compare
imobachgs
changed the title
|
Great improvements ! Just a little thought about the stored settings but feel free to ignore it :-) LGTM |
| # Path to configuration file | ||
| PATH = "/etc/salt/minion".freeze | ||
| PATH = "/etc/salt/minion.d/yast-configuration-management.conf".freeze |
There was a problem hiding this comment.
Very nice to concentrate all YaST specific stuff to one own configuration file.
| - Fix Puppet package installation | ||
| - Handle libzypp's lock to allow installation of packages | ||
| through Salt/Puppet | ||
| - Do not write configuration to disk as it is not needed anymore |
There was a problem hiding this comment.
I have also thought about it some time ago. Do we have all information for a "yast clone_system" and the coming up UI in
/etc/salt/minion.d/yast-configuration-management.conf or would some additional information needed for it ?
There was a problem hiding this comment.
No, we do not have all the details. The configuration that was written, contained some specific details to allow running the provisioner after YaST finished.
IMHO, the yast clone_system and UI can be slightly different to the original intention (some information like the path where states/recipes were downloaded are not needed at all). So probably we'll have to bring back part of that code, but I would do it when we implement such features.
This PR tries to address some issues:
Anyway, it is still a work in progress.