Made -Werror optional.

It is off by default so that it will not block mass tests of new GCC
but we want to enable it in a side repo
to be able to fix newly detected problems relatively early.

Enable with
    osc build --with werror
or
    rake osc:build"[--with werror]"

configure.in.in

@@ -53,7 +53,7 @@ AC_PROG_CXX
 # gnu++0x instead of c++0x so that
 # we do not lose gnu extensions like typeof
 # FIXME: rename to Y2CORE_CXXFLAGS and change in devtools:y2autoconf
-Y2CORE_CFLAGS="-std=gnu++0x -Werror"
+Y2CORE_CFLAGS="-std=gnu++0x"
 AC_SUBST(Y2CORE_CFLAGS) dnl included in CXXFLAGS in YAST2-CHECKS-PROGRAM
 
 AC_CHECK_HEADERS(xcrypt.h)

package/yast2-core.spec

@@ -16,6 +16,12 @@
 #
 
 
+# Optionally treat C/C++ warnings as errors.
+# It is off by default so that it will not block mass tests of new GCC
+# but we want to enable it in a side repo
+# to be able to fix newly detected problems relatively early.
+%bcond_with werror
+
 Name:           yast2-core
 Version:        3.1.20
 Release:        0
@@ -92,6 +98,11 @@ sed -i SUBDIRS -e 's/autodocs//'
 
 export SUSE_ASNEEDED=0 # disable --as-needed until this package is fixed
 
+%if %{with werror}
+export   CFLAGS="${RPM_OPT_FLAGS} -Werror"
+export CXXFLAGS="${RPM_OPT_FLAGS} -Werror"
+%endif
+
 %yast_build
 
 %install