Changes from review

yast · Nov 28, 2017 · 437cebe · 437cebe
1 parent dcf8f37
commit 437cebe
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 1 deletion.
diff --git a/Dockerfile b/Dockerfile
@@ -4,4 +4,5 @@ ENV LANG=POSIX LC_ALL=
 # Remove the preinstalled yast2-core, it interferes with the built one
 # when running the tests... (huh??)
 RUN zypper --non-interactive rm yast2-core
+RUN zypper --non-interactive in jemalloc-devel
 COPY . /usr/src/app
diff --git a/base/src/Makefile.am b/base/src/Makefile.am
@@ -24,6 +24,7 @@ y2base_DEPENDENCIES = $(YAST2CORE)
 
 y2base_LDADD = ${Y2UTIL_LIBS}
 
+# -ljemalloc: workaround for error when jemalloc is dlopened in ruby in old testsuite (bsc#1068883)
 y2base_LDFLAGS =			\
 	-Xlinker --whole-archive	\
 	-ljemalloc              	\

diff --git a/package/yast2-core.changes b/package/yast2-core.changes
@@ -3,7 +3,7 @@ Tue Nov 28 15:08:32 UTC 2017 - jreidinger@suse.com
 
 - add jemalloc dependency for y2base which is used only in old
   testsuite and that workarounds problem with dynamic dlopening
-  of jemalloc in ruby (bsc#106883)
+  of jemalloc in ruby (bsc#1068883)
 - 4.0.1
 
 -------------------------------------------------------------------

diff --git a/package/yast2-core.spec b/package/yast2-core.spec
@@ -44,6 +44,7 @@ BuildRequires:  libtool
 # we have a parser
 BuildRequires:  bison
 BuildRequires:  flex
+# workaround for error when jemalloc is dlopened in ruby in old testsuite (bsc#1068883)
 BuildRequires:  jemalloc-devel
 # incompatible change, parser.h -> parser.hh
 BuildRequires:  automake >= 1.12